作者 tangxvhui

bug #3841

@@ -1731,10 +1731,12 @@ func (srv *SummaryEvaluationService) ConfirmScoreEvaluation(param *command.Confi @@ -1731,10 +1731,12 @@ func (srv *SummaryEvaluationService) ConfirmScoreEvaluation(param *command.Confi
1731 for i := range itemList { 1731 for i := range itemList {
1732 result.ResetTotalRating(itemList[i]) 1732 result.ResetTotalRating(itemList[i])
1733 } 1733 }
  1734 + //存在 超级管理员直接修改填写 总分的情况,此时不重新计算总分
  1735 + if result.TotalScore == "0" || result.TotalScore == "" {
1734 if err := result.EvaluationTotalScore(itemValues); err != nil { 1736 if err := result.EvaluationTotalScore(itemValues); err != nil {
1735 return application.ThrowError(application.TRANSACTION_ERROR, err.Error()) 1737 return application.ThrowError(application.TRANSACTION_ERROR, err.Error())
1736 } 1738 }
1737 - 1739 + }
1738 result.CheckResult = domain.EvaluationCheckCompleted 1740 result.CheckResult = domain.EvaluationCheckCompleted
1739 if err := evaluationRepo.Save(result); err != nil { 1741 if err := evaluationRepo.Save(result); err != nil {
1740 return application.ThrowError(application.TRANSACTION_ERROR, err.Error()) 1742 return application.ThrowError(application.TRANSACTION_ERROR, err.Error())
@@ -1817,9 +1819,6 @@ func (srv *SummaryEvaluationService) GetTargetEvaluationResult(param *command.Qu @@ -1817,9 +1819,6 @@ func (srv *SummaryEvaluationService) GetTargetEvaluationResult(param *command.Qu
1817 if err != nil { 1819 if err != nil {
1818 return nil, application.ThrowError(application.TRANSACTION_ERROR, err.Error()) 1820 return nil, application.ThrowError(application.TRANSACTION_ERROR, err.Error())
1819 } 1821 }
1820 - // if err := transactionContext.StartTransaction(); err != nil {  
1821 - // return nil, application.ThrowError(application.TRANSACTION_ERROR, err.Error())  
1822 - // }  
1823 defer func() { 1822 defer func() {
1824 _ = transactionContext.RollbackTransaction() 1823 _ = transactionContext.RollbackTransaction()
1825 }() 1824 }()
@@ -1907,10 +1906,13 @@ func (srv *SummaryEvaluationService) GetTargetEvaluationResult(param *command.Qu @@ -1907,10 +1906,13 @@ func (srv *SummaryEvaluationService) GetTargetEvaluationResult(param *command.Qu
1907 for i := range itemList { 1906 for i := range itemList {
1908 result.ResetTotalRating(itemList[i]) 1907 result.ResetTotalRating(itemList[i])
1909 } 1908 }
  1909 + //存在 超级管理员直接修改填写 总分的情况,此时不重新计算总分
  1910 + if result.TotalScore == "0" || result.TotalScore == "" {
1910 if err = result.EvaluationTotalScore(itemValues); err != nil { 1911 if err = result.EvaluationTotalScore(itemValues); err != nil {
1911 return nil, application.ThrowError(application.TRANSACTION_ERROR, err.Error()) 1912 return nil, application.ThrowError(application.TRANSACTION_ERROR, err.Error())
1912 } 1913 }
1913 } 1914 }
  1915 + }
1914 1916
1915 // 基础数据 1917 // 基础数据
1916 evaluationBase := srv.getSummaryEvaluation(transactionContext, result) 1918 evaluationBase := srv.getSummaryEvaluation(transactionContext, result)
@@ -50,6 +50,7 @@ const ( @@ -50,6 +50,7 @@ const (
50 type EvaluationStatus string 50 type EvaluationStatus string
51 51
52 const ( 52 const (
  53 + // EvaluationEditTotalScore EvaluationStatus = "completed_by_edit_score" //通过超级管理员直接修改分数完成的
53 EvaluationUncompleted EvaluationStatus = "uncompleted" //未提交填写的内容 54 EvaluationUncompleted EvaluationStatus = "uncompleted" //未提交填写的内容
54 EvaluationCompleted EvaluationStatus = "completed" //已提交填写的内容 55 EvaluationCompleted EvaluationStatus = "completed" //已提交填写的内容
55 ) 56 )