Merge branch 'test' of http://gitlab.fjmaimaimai.com/allied-creation/performance into test
正在显示
1 个修改的文件
包含
9 行增加
和
4 行删除
| @@ -1222,7 +1222,7 @@ func (srv *SummaryEvaluationService) EditEvaluationSuper(param *command.EditEval | @@ -1222,7 +1222,7 @@ func (srv *SummaryEvaluationService) EditEvaluationSuper(param *command.EditEval | ||
| 1222 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) | 1222 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) |
| 1223 | } | 1223 | } |
| 1224 | // 如果目标员工已经确认考核结果,就不能在进行评估编辑 | 1224 | // 如果目标员工已经确认考核结果,就不能在进行评估编辑 |
| 1225 | - if len(evaluationList) > 0 && evaluationList[0].Status == domain.EvaluationCompleted { | 1225 | + if len(evaluationList) > 0 && evaluationList[0].CheckResult == domain.EvaluationCheckCompleted { |
| 1226 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, "用户已经确认该周期的考核结果,不能在编辑!") | 1226 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, "用户已经确认该周期的考核结果,不能在编辑!") |
| 1227 | } | 1227 | } |
| 1228 | 1228 | ||
| @@ -1285,6 +1285,11 @@ func (srv *SummaryEvaluationService) EditEvaluationSuper(param *command.EditEval | @@ -1285,6 +1285,11 @@ func (srv *SummaryEvaluationService) EditEvaluationSuper(param *command.EditEval | ||
| 1285 | 1285 | ||
| 1286 | // EditEvaluationSuperForAdmin 更新上级评估内容(超级管理员) | 1286 | // EditEvaluationSuperForAdmin 更新上级评估内容(超级管理员) |
| 1287 | func (srv *SummaryEvaluationService) EditEvaluationSuperForAdmin(param *command.EditEvaluationValue) (interface{}, error) { | 1287 | func (srv *SummaryEvaluationService) EditEvaluationSuperForAdmin(param *command.EditEvaluationValue) (interface{}, error) { |
| 1288 | + // 超管不接收临时数据提交 | ||
| 1289 | + if param.IsTemporary { | ||
| 1290 | + return nil, nil | ||
| 1291 | + } | ||
| 1292 | + | ||
| 1288 | lock := xredis.NewLockSummaryEvaluationId(param.SummaryEvaluationId) | 1293 | lock := xredis.NewLockSummaryEvaluationId(param.SummaryEvaluationId) |
| 1289 | err := lock.Lock() | 1294 | err := lock.Lock() |
| 1290 | if err != nil { | 1295 | if err != nil { |
| @@ -1331,7 +1336,7 @@ func (srv *SummaryEvaluationService) EditEvaluationSuperForAdmin(param *command. | @@ -1331,7 +1336,7 @@ func (srv *SummaryEvaluationService) EditEvaluationSuperForAdmin(param *command. | ||
| 1331 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) | 1336 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) |
| 1332 | } | 1337 | } |
| 1333 | // 如果目标员工已经确认考核结果,就不能在进行评估编辑 | 1338 | // 如果目标员工已经确认考核结果,就不能在进行评估编辑 |
| 1334 | - if len(evaluationList) > 0 && evaluationList[0].Status == domain.EvaluationCompleted { | 1339 | + if len(evaluationList) > 0 && evaluationList[0].CheckResult == domain.EvaluationCheckCompleted { |
| 1335 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, "用户已经确认该周期的考核结果,不能在编辑!") | 1340 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, "用户已经确认该周期的考核结果,不能在编辑!") |
| 1336 | } | 1341 | } |
| 1337 | 1342 | ||
| @@ -1344,8 +1349,8 @@ func (srv *SummaryEvaluationService) EditEvaluationSuperForAdmin(param *command. | @@ -1344,8 +1349,8 @@ func (srv *SummaryEvaluationService) EditEvaluationSuperForAdmin(param *command. | ||
| 1344 | if err != nil { | 1349 | if err != nil { |
| 1345 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) | 1350 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) |
| 1346 | } | 1351 | } |
| 1347 | - // 超级管理员编辑不限制截止时间 | ||
| 1348 | - err = srv.editEvaluationValueUnlimited(evaluationData, &itemValueList, itemList, param.EvaluationItems, nil, false) | 1352 | + // 超级管理员编辑不限制截止时间、不校验填写项 |
| 1353 | + err = srv.editEvaluationValueUnlimited(evaluationData, &itemValueList, itemList, param.EvaluationItems, nil, true) | ||
| 1349 | if err != nil { | 1354 | if err != nil { |
| 1350 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) | 1355 | return nil, application.ThrowError(application.INTERNAL_SERVER_ERROR, err.Error()) |
| 1351 | } | 1356 | } |
-
请 注册 或 登录 后发表评论