作者 yangfu

重构-我审核的机会

@@ -1678,10 +1678,9 @@ func MyApproveChance(header *protocol.RequestHeader, request *protocol.MyApprove @@ -1678,10 +1678,9 @@ func MyApproveChance(header *protocol.RequestHeader, request *protocol.MyApprove
1678 // 我的收藏 1678 // 我的收藏
1679 func MyCollectChance(header *protocol.RequestHeader, request *protocol.MyCollectChanceRequest) (rsp *protocol.MyCollectChanceResponse, err error) { 1679 func MyCollectChance(header *protocol.RequestHeader, request *protocol.MyCollectChanceRequest) (rsp *protocol.MyCollectChanceResponse, err error) {
1680 var ( 1680 var (
1681 - myChances []protocol.ChanceCollectItemOrm  
1682 - total int  
1683 - provider *protocol.BaseUserInfo  
1684 - favorite *models.ChanceFavorite 1681 + ormItems []protocol.ChanceCollectItemOrm
  1682 + total int
  1683 + favorite *models.ChanceFavorite
1685 ) 1684 )
1686 if request.LastId > 0 { 1685 if request.LastId > 0 {
1687 if favorite, err = models.GetChanceFavoriteById(request.LastId); err != nil { 1686 if favorite, err = models.GetChanceFavoriteById(request.LastId); err != nil {
@@ -1690,7 +1689,7 @@ func MyCollectChance(header *protocol.RequestHeader, request *protocol.MyCollect @@ -1690,7 +1689,7 @@ func MyCollectChance(header *protocol.RequestHeader, request *protocol.MyCollect
1690 } 1689 }
1691 request.LastId = favorite.CollectTime.Unix() 1690 request.LastId = favorite.CollectTime.Unix()
1692 } 1691 }
1693 - if total, err = models.GetChanceCollect(header.UserId, request.LastId, request.PageSize, &myChances); err != nil { 1692 + if total, err = models.GetChanceCollect(header.UserId, request.LastId, request.PageSize, &ormItems); err != nil {
1694 if err == orm.ErrNoRows { 1693 if err == orm.ErrNoRows {
1695 err = nil 1694 err = nil
1696 return 1695 return
@@ -1699,61 +1698,62 @@ func MyCollectChance(header *protocol.RequestHeader, request *protocol.MyCollect @@ -1699,61 +1698,62 @@ func MyCollectChance(header *protocol.RequestHeader, request *protocol.MyCollect
1699 return 1698 return
1700 } 1699 }
1701 rsp = &protocol.MyCollectChanceResponse{Total: total} 1700 rsp = &protocol.MyCollectChanceResponse{Total: total}
1702 - for i := 0; i < len(myChances); i++ {  
1703 - chance := myChances[i] 1701 + for i := 0; i < len(ormItems); i++ {
  1702 + ormItem := ormItems[i]
1704 commItem := &protocol.CommonListItem{} 1703 commItem := &protocol.CommonListItem{}
1705 - commItem.ReviewStatus = chance.ReviewStatus  
1706 - commItem.ChanceId = chance.ChanceId  
1707 - if len(chance.SourceContent) == 0 || chance.ChanceEnableStatus == 0 { //机会删除  
1708 - commItem.ChanceStatus = protocol.ChanceStatusDelete  
1709 - }  
1710 - if chance.Status == models.ChanceStatusClose { //机会关闭  
1711 - commItem.ChanceStatus = protocol.ChanceStatusClose  
1712 - }  
1713 -  
1714 - if chance.ChanceUserId > 0 {  
1715 - if provider, err = agg.GetUserBaseInfo(chance.ChanceUserId, header.CompanyId); err != nil {  
1716 - commItem.ChanceStatus = protocol.ChanceStatusDelete  
1717 - log.Error(err)  
1718 - //return  
1719 - } else {  
1720 - item := protocol.ChanceItem{  
1721 - Id: chance.ChanceId,  
1722 - Provider: provider,  
1723 - CreateTime: chance.CreateTime.Unix() * 1000,  
1724 - PublicStatus: chance.PublishStatus,  
1725 - }  
1726 - jsonUnmarshal(chance.SourceContent, &item.FormList)  
1727 - item.FormList = clearEmptyForm(item.FormList)  
1728 - jsonUnmarshal(chance.Images, &item.Pictures)  
1729 - jsonUnmarshal(chance.Voices, &item.Speechs)  
1730 - jsonUnmarshal(chance.Videos, &item.Videos)  
1731 - commItem.Chance = item  
1732 - }  
1733 - }  
1734 -  
1735 - commItem.ReviewStatus = chance.ReviewStatus 1704 + commItem.Chance, commItem.ChanceStatus = agg.SetChanceItem(header, ormItem.CommChanceItemOrm)
  1705 + commItem.ReviewStatus = ormItem.ReviewStatus
  1706 + commItem.ChanceId = ormItem.ChanceId
  1707 + //if len(ormItem.SourceContent) == 0 || ormItem.ChanceEnableStatus == 0 { //机会删除
  1708 + // commItem.ChanceStatus = protocol.ChanceStatusDelete
  1709 + //}
  1710 + //if ormItem.Status == models.ChanceStatusClose { //机会关闭
  1711 + // commItem.ChanceStatus = protocol.ChanceStatusClose
  1712 + //}
  1713 + //
  1714 + //if ormItem.ChanceUserId > 0 {
  1715 + // if provider, err = agg.GetUserBaseInfo(ormItem.ChanceUserId, header.CompanyId); err != nil {
  1716 + // commItem.ChanceStatus = protocol.ChanceStatusDelete
  1717 + // log.Error(err)
  1718 + // //return
  1719 + // } else {
  1720 + // item := protocol.ChanceItem{
  1721 + // Id: ormItem.ChanceId,
  1722 + // Provider: provider,
  1723 + // CreateTime: ormItem.CreateTime.Unix() * 1000,
  1724 + // PublicStatus: ormItem.PublishStatus,
  1725 + // }
  1726 + // jsonUnmarshal(ormItem.SourceContent, &item.FormList)
  1727 + // item.FormList = clearEmptyForm(item.FormList)
  1728 + // jsonUnmarshal(ormItem.Images, &item.Pictures)
  1729 + // jsonUnmarshal(ormItem.Voices, &item.Speechs)
  1730 + // jsonUnmarshal(ormItem.Videos, &item.Videos)
  1731 + // commItem.Chance = item
  1732 + // }
  1733 + //}
  1734 + //
  1735 + //commItem.ReviewStatus = ormItem.ReviewStatus
1736 { 1736 {
1737 var chanceData = protocol.ChanceData{ 1737 var chanceData = protocol.ChanceData{
1738 - ThumbsUpTotal: chance.ZanTotal,  
1739 - CommentTotal: chance.CommentTotal,  
1740 - PageViewTotal: chance.ViewTotal, 1738 + ThumbsUpTotal: ormItem.ZanTotal,
  1739 + CommentTotal: ormItem.CommentTotal,
  1740 + PageViewTotal: ormItem.ViewTotal,
1741 } 1741 }
1742 - chanceData.IsThumbsUp, chanceData.IsCollect, _ = getChanceMarkFlag(header, chance.ChanceId) 1742 + chanceData.IsThumbsUp, chanceData.IsCollect, _ = getChanceMarkFlag(header, ormItem.ChanceId)
1743 commItem.ChanceData = chanceData 1743 commItem.ChanceData = chanceData
1744 } 1744 }
1745 { 1745 {
1746 //做一次查询 查回所有的模板数据 1746 //做一次查询 查回所有的模板数据
1747 - commItem.ChanceTemplate = getTemplate(chance.TemplateId)  
1748 - commItem.ChanceType = getChanceType(chance.ChanceTypeId) 1747 + commItem.ChanceTemplate = getTemplate(ormItem.TemplateId)
  1748 + commItem.ChanceType = getChanceType(ormItem.ChanceTypeId)
1749 } 1749 }
1750 { 1750 {
1751 collect := protocol.CollectData{ 1751 collect := protocol.CollectData{
1752 - Id: chance.CollectId,  
1753 - CollectTime: chance.CollectTime.Unix() * 1000, 1752 + Id: ormItem.CollectId,
  1753 + CollectTime: ormItem.CollectTime.Unix() * 1000,
1754 } 1754 }
1755 - if collect.CollectTime <= 0 && chance.UpdateTime.Unix() > 0 {  
1756 - collect.CollectTime = chance.UpdateTime.Unix() * 1000 1755 + if collect.CollectTime <= 0 && ormItem.UpdateTime.Unix() > 0 {
  1756 + collect.CollectTime = ormItem.UpdateTime.Unix() * 1000
1757 } 1757 }
1758 //收藏数据 1758 //收藏数据
1759 commItem.CollectData = collect 1759 commItem.CollectData = collect